Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #2949

Merged
merged 74 commits into from
Nov 27, 2023
Merged

Bump dependencies #2949

merged 74 commits into from
Nov 27, 2023

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Nov 21, 2023

The following dependencies are going to be updated.

Verification State Dep Name&Desc
@babel/core
@babel/preset-typescript
@ckb-lumos/base
@ckb-lumos/bi
@ckb-lumos/ckb-indexer
@ckb-lumos/codec
@ckb-lumos/common-scripts
@ckb-lumos/config-manager
@ckb-lumos/hd
@ckb-lumos/helpers
@ckb-lumos/rpc
@jest/globals
@ledgerhq/hw-transport-node-hid
@storybook/testing-library
@types/npmlog
@types/enzyme
@types/enzyme-adapter-react-16
@types/react
@types/react-dom
@types/styled-components
@types/async
@types/electron-devtools-installer
@types/ellipsic
@types/iarna__toml
@types/ledgerhq__hw-transport
@types/ledgerhq__hw-transport-node-hid
@types/leveldown
@types/sqlite3
archiver
async
electron-notarize
electron
concurrently
eslint
eslint-config-prettier
typescript

renovate bot and others added 30 commits November 20, 2023 18:48
….9 (#271)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7 (#256)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…266)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… to v4.22.5 (#257)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v2.2.5 (#268)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Keith-CY Keith-CY marked this pull request as ready for review November 23, 2023 06:00
@Keith-CY
Copy link
Collaborator Author

Ready for review

@yanguoyu
Copy link
Collaborator

yanguoyu commented Nov 23, 2023

/package
After updating the @ledgerhq/hw-transport-node-hid, we'd better check Neuron with the hard wallet. I will check with my Ledger Nano S Plus. Please test with your hard wallet. @silySuper @FrederLu
Packaging for test is done in 6966219308. @yanguoyu

@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Nov 23, 2023

/package After updating the @ledgerhq/hw-transport-node-hid, we'd better check Neuron with the hard wallet. I will check with my Ledger Nano S Plus. Please test with your hard wallet. @silySuper @FrederLu

I've verified this update with Ledger Nano X

@FrederLu
Copy link
Collaborator

/package After updating the @ledgerhq/hw-transport-node-hid, we'd better check Neuron with the hard wallet. I will check with my Ledger Nano S Plus. Please test with your hard wallet. @silySuper @FrederLu

Ok, I'll use the hardware wallet to verify it after it's wrapped.

@yanguoyu
Copy link
Collaborator

Import the hard wallet with Ledger Nano S Plus failed. I will check the reason.
From the log may find the device failed:

[2023-11-23T08:56:44.222Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:56:45.240Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:56:47.112Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:56:48.977Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:56:49.784Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:56:50.248Z] [info]  Database:	saved synced block #11379072
[2023-11-23T08:57:13.393Z] [info]  Find devices:	 [ [] ]
[2023-11-23T08:58:26.482Z] [info]  Database:	saved synced block #11379082
[2023-11-23T09:00:35.000Z] [info]  Database:	saved synced block #11379092
image

@FrederLu
Copy link
Collaborator

Packaging for test is done in 6966219308. @yanguoyu

When importing Ledger Nano X, I also encountered a prompt that the device cannot be detected.
image

1. @ledgerhq/hw-transport-node-hid has update the usb version and set as fixed.
@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Nov 24, 2023

/package
Packaging for test is done in 6976112759. @Keith-CY

@Keith-CY
Copy link
Collaborator Author

/package Packaging for test is done in 6976112759. @Keith-CY

Please verify import a hardwallet with this package @yanguoyu @FrederLu

@yanguoyu
Copy link
Collaborator

/package Packaging for test is done in 6976112759. @Keith-CY

Please verify import a hardwallet with this package @yanguoyu @FrederLu

It works well with Ledger Nano S Plus on import hard wallet, send, withdraw DAO, and deposit DAO

@silySuper
Copy link
Collaborator

My device is same to yanguoyu(Ledger Nano S Plus).My package is the latest.
When I import hardware wallet it shows abnormal.It is my first time to use hardware wallet.
截屏2023-11-24 10 59 30

@yanguoyu
Copy link
Collaborator

My device is same to yanguoyu(Ledger Nano S Plus).My package is the latest. When I import hardware wallet it shows abnormal.It is my first time to use hardware wallet. 截屏2023-11-24 10 59 30

Do you install and open the Nervos app on the device?

@silySuper
Copy link
Collaborator

My device is same to yanguoyu(Ledger Nano S Plus).My package is the latest. When I import hardware wallet it shows abnormal.It is my first time to use hardware wallet. 截屏2023-11-24 10 59 30

Do you install and open the Nervos app on the device?

no,OK,I will download Nervos app.

@FrederLu
Copy link
Collaborator

FrederLu commented Nov 24, 2023

/package Packaging for test is done in 6976112759. @Keith-CY

Please verify import a hardwallet with this package @yanguoyu @FrederLu

image

The package can be imported into the hardware wallet normally, and transaction signatures are also normal.

@Keith-CY
Copy link
Collaborator Author

/package Packaging for test is done in 6976112759. @Keith-CY

Please verify import a hardwallet with this package @yanguoyu @FrederLu

image

The package can be imported into the hardware wallet normally, and transaction signatures are also normal.

Please add an approval if ledger works well with this update

@FrederLu FrederLu self-requested a review November 27, 2023 05:59
@Keith-CY Keith-CY enabled auto-merge November 27, 2023 06:02
@Keith-CY Keith-CY disabled auto-merge November 27, 2023 06:02
@Keith-CY Keith-CY merged commit c530736 into nervosnetwork:develop Nov 27, 2023
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants